domain - set some columns to arbitrary length (TEXT type)

[pmauduit]

In some cases we would need more than the default length for string (255chars), e.g. when using large logos or very long descriptions for our groups in the Console. Using a TEXT type sounds more appropriate than a VARCHAR which would require to raise the max number each time the limit is reached.

As indicated in a comment, this is not portable, but works with postgresql which is the de-facto standard in geOrchestra ? Rapidly checking, it looks like Oracle also supports it.

Tests: runtime tested.

Checklist

• I have read the contribution guidelines
• Pull request provided for main branch, backports managed with label
• Good housekeeping of code, cleaning up comments, tests, and documentation
• Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
• Clean commit messages, longer verbose messages are encouraged
• API Changes are identified in commit messages
• Testing provided for features or enhancements using automatic tests
• User documentation provided for new features or enhancements in manual
• Build documentation provided for development instructions in README.md files
• Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

geOrchestra/geonetwork checklist

• PR only involves cherry-picked commits from upstream.
• PR contains custom code which will soon be available in an upstream release and can be overriden => mention core-geonetwork version if possible.
• PR contains custom geOrchestra code, which need to be verified during future migrations.
  • I have properly filled the migration-helper-changelog.md file.

[f-necas]

The PR templates comes from core-geonetwork and not georchestra/geonetwork, weird ! (while writing this comment, I've seen that there's two PR templates. Can you remove the one in uppercase in this PR ?)

What about @lob annotation, could it be better and upstream-compliant ?

If it doesn't, is it possible to mention georchestra's specific features here :
https://github.com/georchestra/geonetwork/blob/georchestra-gn4.4.x/georchestra-migration/migration-dev-guide.md

I add the PR template to your description.

Anyway, it looks good to me if Lob doesn't work.

[pmauduit]

What about @lob annotation, could it be better and upstream-compliant ?

I think I tried this before using columnDefinition, and it was creating a column using a weird postgresql type, which made JPA fail afterwards.
I'll retry though because I'd like to have the details of what was going wrong.

[pmauduit]

Using @Lob annotation gives the following table layout (e.g. for groups):

georchestra=# \d geonetwork.groups 
                                 Table "geonetwork.groups"
           Column            |          Type          | Collation | Nullable |   Default   
-----------------------------+------------------------+-----------+----------+-------------
 id                          | integer                |           | not null | 
 description                 | oid                    |           |          | 
 email                       | character varying(128) |           |          | 
 enablecategoriesrestriction | character(1)           |           |          | 'n'::bpchar
 logo                        | oid                    |           |          | 
 name                        | character varying(255) |           | not null | 
 referrer                    | integer                |           |          | 
 website                     | character varying(255) |           |          | 
 defaultcategory_id          | integer                |           |          | 

Reading a bit about this oid postgresql datatype, it does not seem to be relevant for our usage. This issue looks pretty similar to what is described here: https://community.vahanacloud.com/t/lob-in-jpa-entity-creating-oid-column-in-postgres-how-can-i-store-them-as-text/1261/2 which actually suggests to use columnDefinition="TEXT" instead.

[f-necas]

Indeed. Let's go for text then. (With a bit of doc in geonetwork migration's files)

[pmauduit]

PR updated

[pmauduit]

GHA is failing, but the same tests are in error when I run maven locally on the georchestra-gn4.4.x branch

[github-actions]

💔 All backports failed

Status	Branch	Result
❌	georchestra-gn4.2.x-24.0	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 304

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details