Attempt fix csw (#275)

* replace only %s * feat: replace query with {@} * feat: replace query with {@}
georchestra · Jan 12, 2024 · 2ea70fe · 2ea70fe
1 parent 417d36b
commit 2ea70fe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/csw-server/src/main/java/org/fao/geonet/kernel/csw/services/getrecords/SearchController.java b/csw-server/src/main/java/org/fao/geonet/kernel/csw/services/getrecords/SearchController.java
@@ -449,7 +449,7 @@ public Element search(ServiceContext context, int startPos, int maxRecords,
 
         try {
             String filterQueryString = esFilterBuilder.build(context, "metadata", false, node);
-            String jsonQuery = String.format(elasticSearchQuery, filterQueryString);
+            String jsonQuery = StringUtils.replace(elasticSearchQuery, "{@}", filterQueryString);
 
             ObjectMapper objectMapper = new ObjectMapper();
             esJsonQuery = objectMapper.readTree(jsonQuery);

diff --git a/csw-server/src/main/java/org/fao/geonet/kernel/csw/services/getrecords/es/CswFilter2Es.java b/csw-server/src/main/java/org/fao/geonet/kernel/csw/services/getrecords/es/CswFilter2Es.java
@@ -67,7 +67,7 @@ public class CswFilter2Es extends AbstractFilterVisitor {
         "            \"must\": [\n" +
         "             %s\n" +
         "            ]\n" +
-        "          ,\"filter\":{\"query_string\":{\"query\":\"%s\"}}}"; //, "minimum_should_match" : 1
+        "          ,\"filter\":{\"query_string\":{\"query\":\"{@}\"}}}"; //, "minimum_should_match" : 1
     private static final String TEMPLATE_OR = " {\"bool\": {\n" +
         "            \"should\": [\n" +
         "             %s\n" +
@@ -77,7 +77,7 @@ public class CswFilter2Es extends AbstractFilterVisitor {
         "            \"should\": [\n" +
         "             %s\n" +
         "            ]\n" +
-        "          ,\"filter\":{\"query_string\":{\"query\":\"%s\"}}, \"minimum_should_match\" : 1}";
+        "          ,\"filter\":{\"query_string\":{\"query\":\"{@}\"}}, \"minimum_should_match\" : 1}";
     private static final String TEMPLATE_MATCH = "{\"query_string\": {\n" +
         "        \"fields\": [\"%s\"],\n" +
         "        \"query\": \"%s\"\n" +

diff --git a/...rver/src/test/java/org/fao/geonet/kernel/csw/services/getrecords/es/CswFilter2EsTest.java b/...rver/src/test/java/org/fao/geonet/kernel/csw/services/getrecords/es/CswFilter2EsTest.java
@@ -93,7 +93,7 @@ private static ObjectNode queryStringPart(String field, String queryString) {
             fieldValues.add(field);
             query.set("fields", fieldValues);
         }
-        query.put("query", queryString == null ? "%s" : queryString);
+        query.put("query", queryString == null ? "{@}" : queryString);
 
         queryStringNode.set("query_string", query);