Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cdata deserialzation #555

Merged
merged 2 commits into from
Dec 11, 2020
Merged

fix cdata deserialzation #555

merged 2 commits into from
Dec 11, 2020

Conversation

cehbrecht
Copy link
Collaborator

@cehbrecht cehbrecht commented Dec 10, 2020

Overview

This PR fixes issue #553. It removes the CDATA tag when loading an input from json.

Related Issue / Discussion

#553

Additional Information

roocs/rook#72

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • [ x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@cehbrecht cehbrecht self-assigned this Dec 10, 2020
@cehbrecht cehbrecht added the bug label Dec 10, 2020
@cehbrecht cehbrecht added this to the 4.4.0 milestone Dec 10, 2020
@cehbrecht cehbrecht requested a review from huard December 10, 2020 19:53
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that another, maybe cleaner option, would be to set the CDATA tag into the xml template, instead of the json representation.

I might have tried to do that originally but could not get all the kinks out. It might be more difficult though to code the necessary logic inside the template.

pywps/inout/inputs.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 10, 2020

Coverage Status

Coverage increased (+0.04%) to 75.484% when pulling 86f96a0 on cehbrecht:fix-553-json-with-cdata into 9fa56cc on geopython:pywps-4.2.

This was referenced Dec 11, 2020
@cehbrecht
Copy link
Collaborator Author

Note that another, maybe cleaner option, would be to set the CDATA tag into the xml template, instead of the json representation.

I might have tried to do that originally but could not get all the kinks out. It might be more difficult though to code the necessary logic inside the template.

I have opened an issue for this #557.

@cehbrecht cehbrecht merged commit a60d3c3 into geopython:pywps-4.2 Dec 11, 2020
@cehbrecht cehbrecht deleted the fix-553-json-with-cdata branch December 11, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants