-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream fixes #60
Open
idanmiara
wants to merge
9
commits into
geopython:master
Choose a base branch
from
talos-gis:upstream_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upstream fixes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/__init__.py; processes, process_descriptor moved to processes/__init__.py; the flask app was moved to app.py app.py - set root and add it to the path, project_root added to the path to allow loading from Apache/iis, app.py, test_execute.py - added if __name__ == "__main__" section app_main_page.py - /sys_path, /test added; flask_response function added processes/buffer.py - make out_filename unique using tempfile to support concurrency processes/jsonprocess.py, sayhello.py, sleep.py - the output is named 'output' in all requests now sleep.py - added delay parameter, some more outputs and set defaults pywps.cfg moved to config/ and added allowedinputpaths=./static/ static/requests/execute_buffer_post*.xml renamed to static/requests/buffer*.xml point.gml, railroads.gml moved to /static/data/shp buffer.py - added filename as output sayhello.py - added default name server url and port are now read correctly from pywps.cfg and not hardcoded in various locations set_root handles setting the root path before loading any files with relative paths tests/test_execute.py - buffer xml name changed
…ges; <b> was replaced with <strong>, which has semantic meaning; Links to outside websites with "target=_blank" should have rel="noopener noreferrer" to prevent phishing attacks
exceptions.py - PyWPS exception classes app_set_server.py - raise specific exception demo.py - there is no point to catch an OSError abd raise a general error; print the error instead.
…ave schema_wps_url as const string tests/test_describe.py - reformat tests/test_capabilities.py - remove unnecessary imports
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/init.py; processes, process_descriptor moved to processes/init.py; the flask app was moved to app.py
app.wsgi added for using via mod_wsgi
app_main_page.py - /sys_path, /test added; flask_response function added
processes/buffer.py - make out_filename unique using tempfile to support concurrency
processes/jsonprocess.py, sayhello.py, sleep.py - the output is named 'output' in all requests now
sleep.py - added delay parameter, some more outputs and set defaults
pywps.cfg moved to config/; added allowedinputpaths=./static/; outputs should be relative to server_url (I can't find any reference for using this value anyway)
static/requests/execute_buffer_post*.xml renamed to static/requests/buffer*.xml
point.gml, railroads.gml moved to /static/data/shp
buffer.py - added filename as output
sayhello.py - added default name
server url and port are now read correctly from pywps.cfg and not hardcoded in various locations
set_root handles setting the root path before loading any files with relative paths
Overview
Refactoring, bugfixes and improvements
Related Issue / Discussion
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)