refactor: throw character name is empty on response from maple

geoje · Dec 11, 2024 · 7040287 · 7040287
1 parent ae1da38
commit 7040287
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/backend/src/main/java/kr/ygh/maple/character/feign/maple/MapleConfig.java b/backend/src/main/java/kr/ygh/maple/character/feign/maple/MapleConfig.java
@@ -1,18 +1,17 @@
 package kr.ygh.maple.character.feign.maple;
 
 import feign.codec.Decoder;
-import kr.ygh.maple.character.dto.basic.Basic;
-import org.jsoup.Jsoup;
-import org.jsoup.nodes.Document;
-import org.jsoup.nodes.Element;
-import org.springframework.context.annotation.Bean;
-
 import java.io.InputStream;
 import java.lang.reflect.Type;
 import java.nio.charset.StandardCharsets;
 import java.util.Map;
 import java.util.Optional;
 import java.util.function.Function;
+import kr.ygh.maple.character.dto.basic.Basic;
+import org.jsoup.Jsoup;
+import org.jsoup.nodes.Document;
+import org.jsoup.nodes.Element;
+import org.springframework.context.annotation.Bean;
 
 public class MapleConfig {
 
@@ -49,7 +48,7 @@ private Basic parseBasic(Document document) {
         String characterName = tdMain
                 .map(tr -> tr.selectFirst("dt > a"))
                 .map(Element::text)
-                .orElse("");
+                .orElseThrow();
         Optional<String> worldImage = tdMain
                 .map(tr -> tr.selectFirst("dt > a > img"))
                 .map(img -> img.attr("src"));