Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme.md for monorepo support #133

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Conversation

Abbbdab
Copy link
Contributor

@Abbbdab Abbbdab commented Mar 21, 2023

Updated documentation for monorepo support, covering the correct approach based on issues / problems I ran into initially.

Abbbdab and others added 3 commits March 21, 2023 15:07
- don't mention specific monorepo tools
- remove extraneous files
- link pnpm issue
- reword some things
@geoffrich
Copy link
Owner

Thanks for the PR! I made some edits - does everything still make sense to you? Anything I took out that shouldn't have been?

I also opened a separate issue for the PNPM failure and linked it in the README, since I think that's an actual bug: #135

@Abbbdab
Copy link
Contributor Author

Abbbdab commented Mar 24, 2023

Sounds good! Closing the PR. Cheers.

@Abbbdab Abbbdab closed this Mar 24, 2023
@geoffrich
Copy link
Owner

Sorry, didn't mean for you to close this - I pushed the changes to this PR.

@geoffrich geoffrich reopened this Mar 27, 2023
@geoffrich geoffrich merged commit 1474f09 into geoffrich:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants