Update std::pow where possible #6188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Dec 11, 2024
gassmoeller
force-pushed
the
update_dynamic_core_3
branch
from
f6196c8 to
cc1452a
Compare
gassmoeller
force-pushed
the
update_dynamic_core_3
branch
from
cc1452a to
a5611e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the promised repeat of #6055 after #6072 was merged. #6072 added a lot of new occurences of std::pow that I had missed in #6055, because they were not qualified with
std.This should catch all the remaining cases that can be replaced with
Utilites::fixed_power.Just for future reference these are the regexes I used:
search:
std::pow\(([^)]*?), *(-*[2,3,4,5])\.*0*\)replace:
Utilities::fixed_power<$2>($1)This PR sits on top of #6187 to avoid conflicts, but that means #6187 has to be merged before this one.