Update gwb to v1.0.0 #6012
Merged
Update gwb to v1.0.0 #6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
reviewed
Aug 21, 2024
contrib/world_builder/CITATION
Outdated
| @misc{gwb-doi-v0.4.0, | ||
| title = {{The Geodynamic World Builder} v0.4.0 [software]}, | ||
| @misc{gwb-doi-v1.0.0, | ||
| title = {{The Geodynamic World Builder} v0.6.0 [software]}, |
There was a problem hiding this comment.
?
Suggested change
| title = {{The Geodynamic World Builder} v0.6.0 [software]}, | |
| title = {{The Geodynamic World Builder} v1.0.0 [software]}, |
contrib/world_builder/CMakeLists.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.13.4) | |||
| cmake_minimum_required(VERSION 2.8.12) | |||
There was a problem hiding this comment.
I think we had adjusted this to 3.13.4 because that is the minimum version for ASPECT
|
But you will have to look into the failing tests, it looks as if your version check might not be working correctly. |
|
And the documentation tester failure should be fixed on a recent master. Could you rebase your PR to confirm? |
MFraters
force-pushed
the
Update_GWB_to_v1.0.0
branch
from
507ccff to
59085fe
Compare
This was referenced Aug 21, 2024
|
@gassmoeller, thanks for the review! The documentation tester is now indeed fixed and I have addressed your other comments. I think the other tests will be fixed as well, but we will have to see :) |
MFraters
force-pushed
the
Update_GWB_to_v1.0.0
branch
from
59085fe to
01bd161
Compare
MFraters
changed the title
|
GWB v1.0.0 has been release (see https://github.com/GeodynamicWorldBuilder/WorldBuilder/releases/tag/v1.0.0), so this should be ready to merge :) |
gassmoeller
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version (version 1.0.0!) of the world builder will be released soon (See GeodynamicWorldBuilder/WorldBuilder#746 for todo's) which is related to the world builder JOSS paper, so it is also time to start the review process to get it into aspect. This pull request will still be update until the final release.