Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport world builder simplify cmake -fPIC #5766

Conversation

MFraters
Copy link
Member

@MFraters MFraters commented Jun 4, 2024

A follow up to #5676 and #5669. @bangerth suggested that the -fPIC flags could also be removed.

The -fPIC flag should be automatically set by cmake, so there is no need to specify it manually.

This is a backport of GeodynamicWorldBuilder/WorldBuilder#736 into aspect.

@tjhei
Copy link
Member

tjhei commented Jun 4, 2024

/usr/bin/ld: lib/libWorldBuilder.a(unity_0_cxx.cxx.o): relocation R_X86_64_PC32 against symbol `_ZTVN12WorldBuilder17CoordinateSystems9CartesianE' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value

@MFraters
Copy link
Member Author

MFraters commented Jun 4, 2024

Yes, it seems that -fPIC is actually needed to get it to work with aspect, but also in the world builder repository. Maybe I need to set something for cmake that it adds it when needed.

@bangerth
Copy link
Contributor

bangerth commented Jun 5, 2024

@MFraters Would you mind updating this accordingly?

@MFraters MFraters force-pushed the backport_world_builder_simplify_cmake_pic branch from c999f48 to 5906e6e Compare June 5, 2024 04:48
@MFraters
Copy link
Member Author

MFraters commented Jun 5, 2024

@MFraters Would you mind updating this accordingly?

Done!

@gassmoeller gassmoeller merged commit 0e0cf5c into geodynamics:main Jun 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants