Skip to content

Commit

Permalink
Merge pull request #6143 from gassmoeller/add_changelog_entry
Browse files Browse the repository at this point in the history
Add changelog entry
  • Loading branch information
gassmoeller authored Nov 8, 2024
2 parents 842075c + 9162b7f commit cbcf865
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions doc/modules/changes/20241108_gassmoeller
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Fixed: Several fixes for the Newton solver that would slow down convergence or
rarely lead to wrong results. The Newton solver and defect correction Picard
solver computed a wrong pressure scaling for the linear solver. This has been
fixed, leading to a reduction in linear solver iterations. The solution
variable temporarily contained the update to the solution when using the Newton
solver or defect correction Picard solver, leading to bugs in models that
assumed the vector contains the values. This has been fixed by always storing
the values of the solution in the variable and never the update. The
Eisenstat-Walker method to compute linear solver tolerances for the Newton
solver would compute too coarse linear residuals leading to poor nonlinear
convergence. This has been fixed.
<br>
(Rene Gassmoeller, Menno Fraters, 2024/11/08)

0 comments on commit cbcf865

Please sign in to comment.