Symbology fixes and finer customizability #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Jun 11, 2024
The fontFamily was incorrectly set to the full canvas font. Ex: 10px sans-serif See https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/font
This avoid getting a black border.
gberaudo
force-pushed
the
symbology_fixes
branch
from
fd77483
to
f707cb4
Compare
Without the feature object customizers have very little information to apply style changes. Now they will be able to look at the feature properties. This is also true for the protected methods of the Vector Encoder.
gberaudo
force-pushed
the
symbology_fixes
branch
from
f707cb4
to
6dfe803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: