Added WMS custom params and WMS customizer entry point #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass all Openlayer WMS params to the custom params per default and added also wms to the customizer so that the user can change any param if he wants to. This solve the issue for TIME layer as well as for TRANSPARENT=true layer in openlayer that needs to pass these parameters as well to print in order to have them printed the same was as they are rendered in ol.
ltshb
added a commit
to geoadmin/web-mapviewer
that referenced
this pull request
Apr 24, 2024
WMS layer based on the WMS specification, prints background in white unless the query parameter TRANSPARENT is set to true. The WMS parameter were not passed to print. Due to this external layers were not transparent and layer with time and/or lang did not print the correct content. This was a bug in the geoblocks/mapfishprint library, see geoblocks/mapfishprint#30 Geoadmin layers have a bug and their default behavior is transparent=true instead of false, see https://jira.swisstopo.ch/browse/PB-439 Also fix
ltkum
pushed a commit
to geoadmin/web-mapviewer
that referenced
this pull request
Apr 29, 2024
WMS layer based on the WMS specification, prints background in white unless the query parameter TRANSPARENT is set to true. The WMS parameter were not passed to print. Due to this external layers were not transparent and layer with time and/or lang did not print the correct content. This was a bug in the geoblocks/mapfishprint library, see geoblocks/mapfishprint#30 Geoadmin layers have a bug and their default behavior is transparent=true instead of false, see https://jira.swisstopo.ch/browse/PB-439 Also fix
ltkum
pushed a commit
to geoadmin/web-mapviewer
that referenced
this pull request
Apr 29, 2024
WMS layer based on the WMS specification, prints background in white unless the query parameter TRANSPARENT is set to true. The WMS parameter were not passed to print. Due to this external layers were not transparent and layer with time and/or lang did not print the correct content. This was a bug in the geoblocks/mapfishprint library, see geoblocks/mapfishprint#30 Geoadmin layers have a bug and their default behavior is transparent=true instead of false, see https://jira.swisstopo.ch/browse/PB-439 Also fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass all Openlayer WMS params to the custom params per default and added also wms to the customizer so that the user can change any param if he wants to.
This solve the issue for TIME layer as well as for TRANSPARENT=true layer in openlayer that needs to pass these parameters as well to print in order to have them printed the same was as they are rendered in ol.