Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-790: Fix failed to print on empty string text drawing. - #minor #1010

Merged

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Jul 24, 2024

This is a dirty fix while waiting this bug fix is merged geoblocks/mapfishprint#35. The #1011 contains the proper fix.

The bug:

  • customizer.feature skips an empty text annotation feature

To reproduce:

  • create an empty text and another drawing item
  • print

Test link

@github-actions github-actions bot changed the title PB-790: Fix failed to print on empty string text drawing. PB-790: Fix failed to print on empty string text drawing. - #minor Jul 24, 2024
Copy link

cypress bot commented Jul 24, 2024



Test summary

210 0 21 0


Run details

Project web-mapviewer
Status Passed
Commit 71427b0
Started Aug 6, 2024 4:33 AM
Ended Aug 6, 2024 4:38 AM
Duration 05:08 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@ismailsunni ismailsunni requested review from pakb, ltkum and ltshb July 30, 2024 03:39
@ismailsunni ismailsunni force-pushed the pb-790-fix-print-editableFeature-error-empty-annotation branch from 9939f0a to 71427b0 Compare August 6, 2024 04:29
@ismailsunni ismailsunni merged commit 21f75cb into master Aug 6, 2024
6 checks passed
@ismailsunni ismailsunni deleted the pb-790-fix-print-editableFeature-error-empty-annotation branch August 6, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants