-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-987: Add item-search to conformance endpoint #465
Conversation
def add_landing_page_version(apps, schema_editor): | ||
LandingPage = apps.get_model("stac_api", "LandingPage") | ||
lp = LandingPage.objects.get(version='v1') | ||
lp.conformsTo.insert(2, 'https://api.stacspec.org/v1.0.0/item-search') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we also need to add conformance to https://api.stacspec.org/v1.0.0/collections/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly we don't fully comply with the "item-search".
We use content-type header application/json
instead of application/geo+json
, this is to optimize cloudfront.
If we don't care about this we could probably also add "https://api.stacspec.org/v1.0.0/ogcapi-features".
I found https://github.com/stac-utils/stac-api-validator useful to help test our conformance.
66048ef
to
68e484e
Compare
c22cac3
to
0348d7d
Compare
@hansmannj there are more problems with conformance for item-search than just the json/geojson stuff so it is probably better to not add that for now |
I ran the conformance validator again with the item-search which returned the following errors. I already removed any geojson issues as we decided to ignore them. The issues are mainly around input validation.
|
Thanks for checking! |
3c78968
to
20a7ac9
Compare
@hansmannj yes, we are conform with https://api.stacspec.org/v1.0.0/collections, and it is already set.
|
Thanks for checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot 🚀
There are multiple issues with item-search confomance (e.g. timestamps) so for now only feature conformance has been added