-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-1112: Use pytest #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you!
I have made some comments along the reviewing concerning the naming of things. It wasn't always a 100% apparent what is what, maybe this gives you a hint for improvements.
f41603e
to
acac686
Compare
Your right, naming was confusing! Cleanup done:
|
acac686
to
76cf636
Compare
76cf636
to
7c6d4d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, you made it even better! Thank you!
This PR improves the test suite, which previously contained a mix of Django and pytest tests. It
app/tests
to align with the structure of the other services__init__.py
files within test folders to prevent test code from being auto-discovered outside of pytestutils/testing.py
to fixture(s) in conftest.py