PB-1044 Add interface for cognito #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msom
force-pushed
the
feat-pb-1044-populate-cognito
branch
from
1b36237
to
474a0e1
Compare
schtibe
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Very nice so far!! 🚀
I have a few remarks in the code.
Some thought I just had:
Would it be good to have an attribute in the pool that is set when the user is managed from service control? So that when we clear and remove users, we only take the ones that have this attribute/flag.
Like this it would be possible to have manually created users that won't be removed by the sync command. This could prove to be handy for debugging purposes, or when we need an admin user of some sort.
(FYI. the build currently fails because of the TODOs in the code)
|
Added, as discussed, a |
msom
force-pushed
the
feat-pb-1044-populate-cognito
branch
from
47df145
to
91fce2e
Compare
asteiner-swisstopo
approved these changes
Oct 24, 2024
msom
force-pushed
the
feat-pb-1044-populate-cognito
branch
from
56abee6
to
1c68348
Compare
schtibe
reviewed
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
cognito.utils.Servicefor managing cognito userscognito.utils.userto be used in the API when creating, deleting and updating a usercognito_syncfor synchronizing users (same base classes used as in PB-1026 Add BOD import command #23, taken fromservice-stac)cognito-localfor local testing and development