project-review-jpreg-index.Rmd #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this project is very well done. The main suggestion I would make it to discuss more than just one single drought (or wet) event shown in the data. |
jpreg
commented
Nov 19, 2019
| @@ -3,7 +3,7 @@ title: "Building, Crossdating, and Analyzing a Tree Ring Chronology from Geneseo | |||
| author: "Greg Bream" | |||
| --- | |||
|
|
|||
| ## Introduction | |||
There was a problem hiding this comment.
Is it standard to only build mean-value chronologies in dendrochronology ? I was wondering if you could compare it to median-value chronology?
jpreg
commented
Nov 19, 2019
| @@ -42,7 +42,7 @@ library(magick) | |||
| ``` | |||
|
|
|||
|
|
|||
| ### Mean Value Chronology | |||
There was a problem hiding this comment.
I would add a line explaining further what Tukey's biweight robust mean means
jpreg
commented
Nov 19, 2019
| @@ -61,7 +61,7 @@ Cross_SEGS <- corr.rwl.seg(QuercusMaster, seg.length = 50, pcrit = 0.10) | |||
| ``` | |||
|
|
|||
|
|
|||
| ### Growth Releases | |||
There was a problem hiding this comment.
Is there a way to include the drought index and the dendro dates on the same graphic? This would help in showing the correlation visually.
|
jpreg comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.