Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Datasources and GridMet Content #7

Merged
merged 8 commits into from
Apr 10, 2024
Merged

Improvements to Datasources and GridMet Content #7

merged 8 commits into from
Apr 10, 2024

Conversation

meghanakr7
Copy link
Collaborator

@meghanakr7 meghanakr7 commented Apr 1, 2024 •
edited
Loading

  1. Added images for dataset
  2. Executed all the cells
  3. Added datset Download code for gridMET and SNOTEL
  4. Added DEM datasource
  5. Resolved comments

@meghanakr7 meghanakr7 marked this pull request as draft April 1, 2024 13:45
@meghanakr7 meghanakr7 marked this pull request as ready for review April 4, 2024 04:02
gokulprathin8
gokulprathin8 requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@gokulprathin8 gokulprathin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes.

book/chapters/datasource.ipynb Outdated Show resolved Hide resolved
book/chapters/datasource.ipynb Outdated Show resolved Hide resolved
book/chapters/datasource.ipynb Show resolved Hide resolved
book/chapters/datasource.ipynb Outdated Show resolved Hide resolved
book/chapters/datasource.ipynb Show resolved Hide resolved
book/chapters/gridmet.ipynb Show resolved Hide resolved
book/chapters/gridmet.ipynb Show resolved Hide resolved
book/chapters/gridmet.ipynb Outdated Show resolved Hide resolved
@meghanakr7 meghanakr7 requested a review from gokulprathin8 April 8, 2024 02:44
gokulprathin8
gokulprathin8 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@gokulprathin8 gokulprathin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM
Good Job!

@gokulprathin8 gokulprathin8 merged commit 81ead6e into main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gokulprathin8 gokulprathin8 gokulprathin8 approved these changes

@ZihengSun ZihengSun Awaiting requested review from ZihengSun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meghanakr7 @gokulprathin8