Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Commit to AMSR #4

Merged
merged 3 commits into from
May 27, 2024
Merged

Initial Commit to AMSR #4

merged 3 commits into from
May 27, 2024

Conversation

srilathamaddineni
Copy link
Collaborator

No description provided.

@srilathamaddineni srilathamaddineni marked this pull request as draft March 29, 2024 19:42
@srilathamaddineni srilathamaddineni marked this pull request as ready for review March 30, 2024 16:50
ZihengSun
ZihengSun reviewed Apr 2, 2024
View reviewed changes
book/chapters/amsr.ipynb Outdated
" end_year = 2022\n",
"\n",
" links = generate_links(start_year, end_year)\n",
" save_location = \"C:/Users/srila/gridmet_test_run/amsr\"\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't use your personal directory path in any of the notebooks. Please change it to relative path and make sure it works on all people's laptops.

ZihengSun
ZihengSun requested changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@ZihengSun ZihengSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

@srilathamaddineni srilathamaddineni marked this pull request as draft April 4, 2024 21:31
@saivivek116
Copy link
Collaborator

saivivek116 commented Apr 5, 2024 •
edited
Loading

  • The headings need to be more explanative currently the headings are function names instead you can give meaningful headings

  • As there are several functions in this chapter(divide into sub chapters if needed) its better you try to make it more engaging with headings, explanations and graphs

  • explanation of the code inside function and the purpose of the function can be separated( into different paragraphs) divide the larger function into chunks

  • give conclusion of the chapter

  • remove unused code

  • Once the paths are modified and respective files needed to execute the notebook are uploaded will verify further

@saivivek116 saivivek116 self-requested a review April 5, 2024 04:37
saivivek116
saivivek116 requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@saivivek116 saivivek116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check my comments.

@srilathamaddineni srilathamaddineni marked this pull request as ready for review April 6, 2024 16:40
@ZihengSun
Copy link
Collaborator

@saivivek116 please help with this PR by directly contributing to the content.

@saivivek116 saivivek116 self-requested a review May 20, 2024 21:14
ZihengSun
ZihengSun approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@ZihengSun ZihengSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge this PR. @saivivek116 please correct the two left issues in separate PRs.

@ZihengSun ZihengSun merged commit b83e8b6 into main May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZihengSun ZihengSun ZihengSun approved these changes

@gokulprathin8 gokulprathin8 Awaiting requested review from gokulprathin8

@saivivek116 saivivek116 Awaiting requested review from saivivek116

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srilathamaddineni @saivivek116 @ZihengSun @gokulprathin8