Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial documentation changes of feature selection and time series chapters #3

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

saivivek116
Copy link
Collaborator

No description provided.

@saivivek116 saivivek116 marked this pull request as ready for review March 30, 2024 16:24
Copy link
Collaborator

@ZihengSun ZihengSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Can you replace all the absolute path in your home directory to relative path and make sure all the CSV files are available for anyone who wants to run the notebook?

Also, how big are those CSVs? If they are exceeding the file size limit in GitHub, shrink them and make some demo CSVs and upload them.

@saivivek116
Copy link
Collaborator Author

saivivek116 commented Mar 30, 2024

updated to relative paths and also pushed the csv files

@saivivek116 saivivek116 requested a review from ZihengSun March 31, 2024 17:33
Copy link
Collaborator

@ZihengSun ZihengSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ZihengSun ZihengSun merged commit 7a640bc into main Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants