Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added double counter, Requesting help #58

Closed
wants to merge 1 commit into from

Conversation

rhayes2
Copy link

@rhayes2 rhayes2 commented Oct 31, 2018

Wont be merge,
For those who wished for dual counters I did abit of work on it. need to do more.
As for now its a function MTG lifecounter

@rhayes2 rhayes2 mentioned this pull request Oct 31, 2018
Copy link
Owner

@gentlecat gentlecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but a lot of files show up in a diff while nothing seems to be modified in them. What's going on with that?

@rhayes2
Copy link
Author

rhayes2 commented Nov 1, 2018

Yeah its odd, Ill see if I can get any insight from someone more knowledgeable tomorrow. I attempted to keep the same structure but there's still a lot of things Im learning plus just the way parts were built made it hard to keep persistence without restructuring . At this stage its more proof of concept for me to keep working / learning . HalosGhost did say a double counter would be nice for MTG so i took up the challenge and learned some things about your app. Ill try and do more right after this semester (last one) !!

@HalosGhost
Copy link

Just to clarify, the table I wrote in #49 was not meant to be taken as a double-counter, but rather an example of a multi-counter view that was currently showing two counters. That is, for my use-case, I would much prefer having an arbitrary set of counters. But incremental work is never a problem!

@gentlecat
Copy link
Owner

I'll close this for now folks, feel free to (re)open anytime.

Unrelated files might be showing up because there are some kind of automatic changes that your OS is making. I'd double check the list before creating a commit.

@gentlecat gentlecat closed this Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants