Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops deployment 6 create and test noctua developer deployment docs #13

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

mugitty
Copy link

@mugitty mugitty commented Nov 18, 2024

@mugitty mugitty requested a review from kltm November 18, 2024 23:55
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mugitty Overall this looks good--thank you!

I was wondering about the removal of the bot filtering from the apache vhost setups. As we've bot issues in the past, we put those in. Was there a problem with them?

Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to remove or elide hyper specific information, like ssh fingerprint information?

#### Copy the ssh keys from your docker host into the running docker image, in `/tmp`:

These commands may have to be executed from a separate terminal that can run Docker commands.
See Prerequisites 2 for keys and copy keys from SpderOak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the reference to SpiderOak here? We'll do that for developer onboarding (hopefully). I'd ideally like to avoid some specifics here. Paranoia.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - Security is paramount. I have updated the documentation to remove reference to SpiderOak

@kltm
Copy link
Member

kltm commented Nov 19, 2024

This is really looking good!

@mugitty
Copy link
Author

mugitty commented Nov 20, 2024

@kltm, I will update as requested and let you know when it is ready

@mugitty
Copy link
Author

mugitty commented Nov 20, 2024

@mugitty Overall this looks good--thank you!

I was wondering about the removal of the bot filtering from the apache vhost setups. As we've bot issues in the past, we put those in. Was there a problem with them?

Thanks for flagging. Rewrite rule has precedence over Redirect and order in configuration file does not make a difference. I updated the Apache vhost configuration files to include RewriteRule for bots

@mugitty
Copy link
Author

mugitty commented Nov 20, 2024

@kltm, I will update as requested and let you know when it is ready

I have addressed the issues @kltm mentioned. I also made a minor update to the documentation about checking out Minerva code before building.

@kltm
Copy link
Member

kltm commented Nov 20, 2024

@mugitty Great--thank you! I'll check again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants