-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devops deployment 6 create and test noctua developer deployment docs #13
base: main
Are you sure you want to change the base?
Devops deployment 6 create and test noctua developer deployment docs #13
Conversation
…eveloper-deployment-docs
…eveloper-deployment-docs
…eveloper-deployment-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mugitty Overall this looks good--thank you!
I was wondering about the removal of the bot filtering from the apache vhost setups. As we've bot issues in the past, we put those in. Was there a problem with them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to remove or elide hyper specific information, like ssh fingerprint information?
production/PRODUCTION_README.md
Outdated
#### Copy the ssh keys from your docker host into the running docker image, in `/tmp`: | ||
|
||
These commands may have to be executed from a separate terminal that can run Docker commands. | ||
See Prerequisites 2 for keys and copy keys from SpderOak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the reference to SpiderOak here? We'll do that for developer onboarding (hopefully). I'd ideally like to avoid some specifics here. Paranoia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - Security is paramount. I have updated the documentation to remove reference to SpiderOak
This is really looking good! |
@kltm, I will update as requested and let you know when it is ready |
Thanks for flagging. Rewrite rule has precedence over Redirect and order in configuration file does not make a difference. I updated the Apache vhost configuration files to include RewriteRule for bots |
@mugitty Great--thank you! I'll check again. |
For geneontology/devops-documentation#6