Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parameter for output directory #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added parameter for output directory #6

wants to merge 1 commit into from

Conversation

genericdata
Copy link
Contributor

No description provided.

@mohammedkhalfan
Copy link
Contributor

Should the default for the new parameter, output_dir, be an empty string instead of None? Because you perform string concatenation with this parameter and you can't cat a string and a NoneType object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genericdata @mohammedkhalfan