Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example on how to use testing-library with typescript #990

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shadowusr
Copy link
Member

No description provided.

@shadowusr shadowusr marked this pull request as draft August 9, 2024 11:55
Copy link
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this example really work? Because I don't see testplane config and open url in test example. Looks like it should not work. Can we fix it?

@@ -0,0 +1,20 @@
{
"name": "m-t-l-e",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean? Why not just use folder name?

"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add a testplane launch here?

@@ -0,0 +1,16 @@
import type {} from "testplane";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it for? Mistake or some hack?


it("example", async ({browser}) => {
// testing library matcher
await expect(browser.$("some elem")).toContainHTML("<span>some html</span>");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't understand where code with open some url?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants