Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore TargetCloseError #874

Merged
merged 1 commit into from
Mar 14, 2024
+1 −1
Merged

fix: ignore TargetCloseError #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export const shouldIgnoreUnhandledRejection = (err: Error | undefined): boolean
return false;
}

if (err.name === "ProtocolError") {
if (err.name === "ProtocolError" || err.name === "TargetCloseError") {
Copy link
Member Author

@KuznetsovRoman KuznetsovRoman Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил это условие в существующий if, потому что ProtocolError и TargetCloseError настолько близки, что ProtocolError может быть с сообщением TargetCloseError:

TargetCloseError: Protocol error (Runtime.callFunctionOn): Target closed

return true;
}

Expand Down
Loading