fix: log full error object if default toString is not enough #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+12
to
+18
| const stringifyError = error => { | ||
| try { | ||
| return error.toString() === "[object Object]" ? JSON.stringify(error) : error; | ||
| } catch { | ||
| return error; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Предлагаю подстраховаться и сделать так:
return !error || typeof error === "object"
? JSON.stringify(error)
: error;typeof дает object как раз только на всякие null и объекты, а такая логика с toString не будет работать в редких кейсах, когда Symbol.toStringTag переопределен, или еще что-то странное прокинут в ошибку. Например, массив/дату/промис/...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done?
On rare occasions, error may be some exotic object which can't be properly stringified and is displayed as
[object Object]. This PR changes this behaviour so that if defaulttoStringis not informative,JSON.stringify()version is displayed.