chore: hermione -> testplane #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
force-pushed
the
rebranding
branch
from
1c9183c to
66abad2
Compare
miripiruni
reviewed
Apr 5, 2024
miripiruni
approved these changes
Apr 5, 2024
sipayRT
approved these changes
Apr 7, 2024
| "name": "hermione-oauth", | ||
| "version": "2.0.0", | ||
| "name": "@testplane/oauth", | ||
| "version": "0.0.1", |
| const hermioneMock = (browsers: Record<string, Hermione.BrowserConfig>): Hermione => { | ||
| const emitter = new EventEmitter() as unknown as Hermione; | ||
| const testplaneMock = (browsers: Record<string, BrowserConfig>): Testplane => { | ||
| const emitter = new EventEmitter() as any; |
There was a problem hiding this comment.
Why did you decide to add ant here instead of the old variant?
There was a problem hiding this comment.
Because later we are trying to set some properties of emitter. And we can't do that since hermione@8: those are readonly:
Cannot assign to 'events' because it is a read-only property.
Cannot assign to 'config' because it is a read-only property.
KuznetsovRoman
force-pushed
the
rebranding
branch
from
66abad2 to
6c25963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.