Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate docs #6

Merged
merged 2 commits into from
Jun 23, 2024
Merged

feat: migrate docs #6

merged 2 commits into from
Jun 23, 2024

Conversation

shadowusr
Copy link
Member

@shadowusr shadowusr commented Jun 19, 2024 •
edited
Loading

What's done:

  • Added translations to landing
  • Updated styles and colours in docs
  • Migrated english and russian docs to MDX

Useful links

How to review

  • MDX files were just migrated without major changes
  • Feel free to open the docs website beta and review the end result instead of looking through thousands of lines in mdx files

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

✅ Successfully deployed static

KuznetsovRoman
KuznetsovRoman approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@KuznetsovRoman KuznetsovRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В остальном - /ok

docs/quickstart/index.mdx Outdated Show resolved Hide resolved
docs/quickstart/index.mdx Outdated Show resolved Hide resolved
docs/migrations/how-to-upgrade-hermione-to-4.mdx Outdated Show resolved Hide resolved
docs/index.mdx Show resolved Hide resolved
docs/plugins/hermione-assert-view-extended.mdx Outdated Show resolved Hide resolved
docs/commands/expect/network-matchers.mdx Outdated Show resolved Hide resolved
@miripiruni miripiruni self-requested a review June 19, 2024 12:00
miripiruni
miripiruni requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@miripiruni miripiruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Досмотрел до docs/commands/browser/savePDF.mdx. ПР очень большой, я поделю ревью на несколько заходов. Если не вернусь за сутки, то не жди, пожалуйста.

Нужно поправить пару важных замечаний (в посте про ребрендинг и про видео)

blog/component-testing.mdx Outdated Show resolved Hide resolved
blog/component-testing.mdx Show resolved Hide resolved
blog/component-testing.mdx Outdated Show resolved Hide resolved
blog/component-testing.mdx Outdated Show resolved Hide resolved
blog/component-testing.mdx Outdated Show resolved Hide resolved
blog/rebranding.mdx Outdated Show resolved Hide resolved
docs/commands/browser/$.mdx Outdated Show resolved Hide resolved
docs/commands/browser/action.mdx Outdated Show resolved Hide resolved
docs/commands/browser/action.mdx Show resolved Hide resolved
docs/commands/browser/action.mdx Outdated Show resolved Hide resolved
sipayRT
sipayRT approved these changes Jun 20, 2024
View reviewed changes
docs/commands/browser/assertView.mdx Outdated Show resolved Hide resolved
docs/commands/browser/action.mdx Show resolved Hide resolved
@shadowusr shadowusr merged commit bbfc40e into master Jun 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miripiruni miripiruni miripiruni requested changes

@KuznetsovRoman KuznetsovRoman KuznetsovRoman approved these changes

@sipayRT sipayRT sipayRT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shadowusr @miripiruni @sipayRT @KuznetsovRoman