-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement animated features demo component #4
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<link rel="preconnect" href="https://fonts.googleapis.com" /> | ||
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Jost:ital,wght@0,100..900;1,100..900&family=Roboto+Mono:ital,wght@0,100..700;1,100..700&display=swap" | ||
rel="stylesheet" | ||
/> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ import geminiTesting from "eslint-config-gemini-testing"; | |
import reactRecommended from "eslint-plugin-react/configs/recommended.js"; | ||
import reactJsxRuntime from "eslint-plugin-react/configs/jsx-runtime.js"; | ||
import prettier from "eslint-config-prettier"; | ||
import _ from "lodash"; | ||
import tseslint from "typescript-eslint"; | ||
|
||
export default tseslint.config( | ||
|
@@ -47,7 +48,11 @@ export default tseslint.config( | |
reactRecommended, | ||
reactJsxRuntime, | ||
{ | ||
rules: geminiTesting.rules, | ||
rules: _.omit(geminiTesting.rules, [ | ||
// Rules that conflict with typescript-eslint. | ||
"no-undef", | ||
"no-unused-vars", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we need to exclude this rule? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because it conflicts with typescript-eslint, as stated in the comment above. It provides its own rule, |
||
]), | ||
}, | ||
prettier, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where can I view these rules? can't find them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we extend storybook's webpack config with some custom rules. By adding
...config.module.rules
we make sure to include original rules, we don't want to throw them away when adding ours.Docs: https://storybook.js.org/docs/api/main-config-webpack-final