fix: correctly build link to error details #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Oct 3, 2024
| @@ -21,7 +20,7 @@ export class TreeTestResultTransformer { | |||
| return { | |||
| ..._.omit(result, 'imagesInfo'), | |||
| attempt: testResult.attempt, | |||
| errorDetails: extractErrorDetails(testResult) | |||
| errorDetails: testResult.errorDetails | |||
There was a problem hiding this comment.
We don't have tests for these files
sipayRT
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
It turned out that after refactoring,
extractErrorDetailsis called several times - https://github.com/gemini-testing/html-reporter/blob/v10.7.0/lib/adapters/test-result/utils/index.ts#L50-L64 which builds the path to the file and callsDate.now()inside it. As a result, each call generates a unique path. And one is used for link inside html-reporter and another for save file in folder.Now we will use the already existing value.