Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new-ui): add ability to accept and undo screenshots #605

Merged

Conversation

shadowusr
Copy link
Member

@shadowusr shadowusr commented Oct 2, 2024

⚠️ Only last three commits need review.

What's done:

  • Ability to accept/undo screenshots
  • Tweaks to tinder mode, including compact attempt picker and status display
  • Other minor fixes

Test report: https://nda.ya.ru/t/TDDrfcZG78eWpd

Copy link
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current questions:

  • diff inside Visual checks looks like has incorrect dimension (example: Diff1192034px ⋅ 99.5%)
  • should we render in Visual checks retries which doesn't fail with image comparison?

@shadowusr shadowusr force-pushed the users/shadowusr/TESTPLANE-249.accepting-screenshots branch from 8a06b4e to 5800b73 Compare October 8, 2024 22:04
@shadowusr
Copy link
Member Author

diff inside Visual checks looks like has incorrect dimension

It's actually correct, it contains not image dimensions but amount of pixels and % that are different.

should we render in Visual checks retries which doesn't fail with image comparison?

This question we talked about privately as well and agreed that for now we should keep current behavior:

  • Speaking of retries that don't have such image at all, this case is very rare and displaying all retries adds consistency to the UI
  • Considering showing successful retries in general, we keep it for the same reason of consistency & in the future we'll have filtering capabilities on the left

@shadowusr shadowusr merged commit 503a9a5 into master Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants