fix(gui): wrong base url for tests in gui mode #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
force-pushed
the
sp.fixAbsUrlGui
branch
from
bc54f73 to
48192ff
Compare
DudaGod
approved these changes
Sep 9, 2024
lib/common-utils.ts
Outdated
| @@ -72,21 +72,23 @@ export const determineFinalStatus = (statuses: TestStatus[]): TestStatus | null | |||
|
|
|||
| export const getUrlWithBase = (url: string | undefined, base: string | undefined): string => { | |||
| try { | |||
| if (isEmpty(base)) { | |||
There was a problem hiding this comment.
It looks like that we can write this code outside try statement, because i don't see what can trigger an error in this code.
| @@ -41,7 +41,7 @@ class ViewInBrowser extends Component { | |||
| return ( | |||
| <a | |||
| className={className} | |||
| href={getUrlWithBase(getRelativeUrl(suiteUrl), baseHost)} | |||
| href={getUrlWithBase(suiteUrl, baseHost)} | |||
There was a problem hiding this comment.
what was the problem with using getRelativeUrl method?
There was a problem hiding this comment.
in case of empty baseHost relative path will be returned:
getUrlWithBase(getRelativeUrl("https://ya.ru/some/path"), null); ==> /some/path
and such relative paths will be resolved in the browser relative to the report host
sipayRT
force-pushed
the
sp.fixAbsUrlGui
branch
2 times, most recently
from
c2e7861 to
f397923
Compare
sipayRT
force-pushed
the
sp.fixAbsUrlGui
branch
from
f397923 to
82a9e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.