fix: do not fail when extend error with snippet #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Aug 1, 2024
| @@ -331,7 +331,7 @@ const cloneError = <T extends Error>(error: T): T => { | |||
| }; | |||
|
|
|||
| export const mergeSnippetIntoErrorStack = <T extends Error>(error: T & { snippet?: string }): T => { | |||
| if (!error.snippet) { | |||
| if (!error || !error.snippet) { | |||
There was a problem hiding this comment.
the problem was reproduced by the user a couple of times, but i can't reproduce it on the same project. So add this condition in order to not fail here anymore.
|
It looks like there is nothing to review, so I merge it. |
DudaGod
force-pushed
the
TESTPLANE-163.handle_error_with_snippet
branch
from
9502faf to
d6ff05f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.