Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor test body using GravityUI #573

Merged
merged 12 commits into from
Jul 18, 2024
Merged

Conversation

Kabir-Ivan
Copy link
Contributor

No description provided.

@Kabir-Ivan Kabir-Ivan force-pushed the use-gravity-ui-body branch from e71515c to ed45f7c Compare July 12, 2024 11:21
@Kabir-Ivan Kabir-Ivan force-pushed the use-gravity-ui-body branch from 45a7100 to 3786c33 Compare July 15, 2024 15:13
@shadowusr
Copy link
Member

This panel in GUI mode has a few issues:

@shadowusr
Copy link
Member

Entries in history are not selectable. We should be able to select and copy contents of history as a regular text.

@shadowusr
Copy link
Member

Eye button in the "switch accept mode" is not positioned right:

@shadowusr
Copy link
Member

Diff mode select in switch accept mode isn't displaying full option name, despite having more than enough space to do so:

@shadowusr
Copy link
Member

Here we should have share button, not copy button:

@shadowusr
Copy link
Member

Eye button appears disabled, even though URL is available and upon click it actually sends us to the corresponding page. It shouldn't be disabled then.

@shadowusr
Copy link
Member

There's no difference between currently running test and never launched test:

I suggest we draw a rotating spinner instead of the run button for currently running tests: https://gravity-ui.com/components/uikit/spin

@shadowusr
Copy link
Member

"retry" buttons do not become disabled while tests are running, but they should:

@shadowusr
Copy link
Member

Retry buttons have arrows pointed in different directions and of different sizes. I suggest making them of the exact same size and pointed to the right.

@shadowusr
Copy link
Member

Tests that were never run and currently running tests have a weird collapsible arrow that does nothing. It either shouldn't be there at all or should display something.

@shadowusr
Copy link
Member

Slider on the onion skin tab is not from Gravity UI, but it should be:

https://gravity-ui.com/components/uikit/slider

@shadowusr
Copy link
Member

Arrows on buttons in switch accept mode are not centered:

@shadowusr
Copy link
Member

Undo should have an icon from Gravity UI too:

The one you're using in the retry button next to test title may be a good fit.

@shadowusr
Copy link
Member

When I click on/off checkboxes, test titles stutter, but they shouldn't:

Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting is pretty inconsistent. I understand that linter doesn't work now, but let's at least keep formatting right in the new code. What I noticed: {item} vs { item }, incorrect indents

Also I'm still in doubts about the new colors for attempts. I do like them, but I'll ask our users if they like them too. Because some can definitely say that they are too bleak and red is indistinguishable from pink.

Other than that — great PR and good job! Just need a few more fixes.

@shadowusr
Copy link
Member

And one more thing: when launching a test in GUI, attempt which is running appears yellow. But should be white, because yellow in attempt switcher is reserved for future use

@shadowusr
Copy link
Member

shadowusr commented Jul 16, 2024

Another issue I've noticed:

Long text overflows the container

This applies to error stack traces and other fields as well.

Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stacktraces need to be in mono font. Other than that, everything's great!

@Kabir-Ivan Kabir-Ivan merged commit c63919e into master Jul 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants