-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor test body using GravityUI #573
Conversation
e71515c
to
ed45f7c
Compare
refactor: use one argument with all options inside report builders
45a7100
to
3786c33
Compare
This panel in GUI mode has a few issues:
|
Entries in history are not selectable. We should be able to select and copy contents of history as a regular text. |
There's no difference between currently running test and never launched test: I suggest we draw a rotating spinner instead of the run button for currently running tests: https://gravity-ui.com/components/uikit/spin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting is pretty inconsistent. I understand that linter doesn't work now, but let's at least keep formatting right in the new code. What I noticed: {item}
vs { item }
, incorrect indents
Also I'm still in doubts about the new colors for attempts. I do like them, but I'll ask our users if they like them too. Because some can definitely say that they are too bleak and red is indistinguishable from pink.
Other than that — great PR and good job! Just need a few more fixes.
And one more thing: when launching a test in GUI, attempt which is running appears yellow. But should be white, because yellow in attempt switcher is reserved for future use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stacktraces need to be in mono font. Other than that, everything's great!
No description provided.