fix: result state after screenshot-accepter image accept #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Jun 26, 2024
Comment on lines
+176
to
+179
| const latestAttempt = reportBuilder.getLatestAttempt({ | ||
| fullName: updateResult.fullTitle(), | ||
| browserId: updateResult.browserId | ||
| }); |
There was a problem hiding this comment.
updateResult has TestplaneTestResult type.
Since reportBuilder is not currently tied to Testplane, im not bringing Testplane* to reportBuilder either.
KuznetsovRoman
force-pushed
the
TESTPLANE-105.fix_result_state
branch
from
7530a86 to
8a17382
Compare
DudaGod
approved these changes
Jun 26, 2024
|
|
||
| reportBuilder.getLatestAttempt.withArgs({fullName: 'some-title', browserId: 'yabro'}).returns(100500); | ||
| reportBuilder.getUpdatedReferenceTestStatus = (result) => { | ||
| return result.attempt === 100500 ? TestStatus.UPDATED : TestStatus.FAIL; |
There was a problem hiding this comment.
А зачем это условие? Можно же просто застабать getUpdatedReferenceTestStatus и при вызове его с 100500 возвращать необходимый статус
There was a problem hiding this comment.
Действительно. Исправил.
KuznetsovRoman
force-pushed
the
TESTPLANE-105.fix_result_state
branch
from
8a17382 to
fa18026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to calc new result state based on the latest result, not the current one