feat: display differentPixels, if available #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
force-pushed
the
HERMIONE-1403.html_reporter_diff
branch
3 times, most recently
from
6b9556b to
0217fb0
Compare
sipayRT
reviewed
Mar 4, 2024
KuznetsovRoman
commented
Mar 4, 2024
Comment on lines
137
to
141
| if (percent > 1) { | ||
| return percentString.slice(0, 4); | ||
| } | ||
|
|
||
| return percentString.slice(0, 5); |
There was a problem hiding this comment.
This could be written in ternary form, but .slice(0, percent > 1 ? 4 : 5) is ugly
There was a problem hiding this comment.
example values:
- < 0.001% (because 1 pixel out of full hd picture is 0.00004%, which is a lot of digits)
- 10.4% (because we don't need second digit after
., if percent > 10 - 5.45% (because in this case second digit could be usefull
- 0.015% (because usually we would see that much of a difference, if it comes to percent values
| return <div className={className} onClick={this.onToggleStateResult}>{image.stateName}</div>; | ||
| let displayedText = image.stateName; | ||
|
|
||
| if (image.differentPixels && image.diffRatio) { |
There was a problem hiding this comment.
Those are absent in proptypes so we dont get errors in case they are not defined
| return `< ${percentThreshold}` | ||
| } | ||
|
|
||
| return String(percentRounded); |
There was a problem hiding this comment.
Wrapped in String(), so this method only returns string values
sipayRT
approved these changes
Mar 4, 2024
KuznetsovRoman
force-pushed
the
HERMIONE-1403.html_reporter_diff
branch
from
31f5984 to
4278c26
Compare
KuznetsovRoman
force-pushed
the
HERMIONE-1403.html_reporter_diff
branch
from
4278c26 to
aeb47d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
hermione types fix: gemini-testing/testplane#852