feat(merge-reports): ability to pass headers for databaseUrls.json files #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Jan 15, 2024
| const [key, ...values] = header.split('='); | ||
| return _.set(acc, key, values.join('=')); | ||
| }, {}); | ||
| const parsedHeaders = {...headersFromCli, ...headersFromEnv}; |
There was a problem hiding this comment.
Хедеры из переменной окружения имеют больший приоритет.
| try { | ||
| headersFromEnv = JSON.parse(process.env.html_reporter_headers || '{}'); | ||
| } catch (e) { | ||
| throw new Error(`Couldn't parse headers from "html_reporter_headers" env variable: ${e.message}`); |
There was a problem hiding this comment.
Нужно докидывать понятное сообщение о ошибке иначе будет отображаться стандартная ошибка из json.parse (нефига не понятная)
| @@ -63,7 +63,7 @@ | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.22.5", | |||
| "@gemini-testing/sql.js": "^2.0.0", | |||
| "axios": "^0.18.1", | |||
| "axios": "^1.6.5", | |||
There was a problem hiding this comment.
Заодно апнул версию axios (по идее проблем быть не должно)
DudaGod
force-pushed
the
HERMIONE-1330.merge_reports_send_headers
branch
from
54ba855 to
0ba9568
Compare
sipayRT
approved these changes
Jan 16, 2024
lib/merge-reports/index.js
Outdated
| const jsonUrls = []; | ||
| const dbUrls = []; | ||
|
|
||
| if (serverUtils.isDbUrl(url)) { | ||
| dbUrls.push(url); | ||
| } else if (serverUtils.isJsonUrl(url)) { | ||
| try { | ||
| const {data} = await axios.get(url); | ||
| console.log('headers:', headers); |
DudaGod
force-pushed
the
HERMIONE-1330.merge_reports_send_headers
branch
from
0ba9568 to
2c7a19b
Compare
DudaGod
force-pushed
the
HERMIONE-1330.merge_reports_send_headers
branch
from
2c7a19b to
a367122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to send headers for download databaseUrls.json files