-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: streamline ReporterTestResult and imagesInfo types #526
Merged
shadowusr
merged 7 commits into
master
from
users/shadowusr/1004.get-rid-of-prepared-result-2
Jan 9, 2024
Merged
refactor: streamline ReporterTestResult and imagesInfo types #526
shadowusr
merged 7 commits into
master
from
users/shadowusr/1004.get-rid-of-prepared-result-2
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowusr
force-pushed
the
users/shadowusr/1004.get-rid-of-prepared-result-2
branch
from
December 19, 2023 22:27
7d7ee9b
to
400731c
Compare
shadowusr
force-pushed
the
users/shadowusr/1004.get-rid-of-prepared-result-2
branch
from
December 20, 2023 23:25
400731c
to
bbe2428
Compare
shadowusr
changed the title
Users/shadowusr/1004.get rid of prepared result 2
refactor: streamline ReporterTestResult and imagesInfo types
Dec 20, 2023
shadowusr
force-pushed
the
users/shadowusr/1004.get-rid-of-prepared-result-2
branch
from
December 20, 2023 23:51
78909a4
to
d0b04cb
Compare
shadowusr
commented
Dec 20, 2023
shadowusr
commented
Dec 20, 2023
shadowusr
commented
Dec 20, 2023
shadowusr
commented
Dec 21, 2023
shadowusr
commented
Dec 21, 2023
shadowusr
commented
Dec 21, 2023
shadowusr
commented
Dec 21, 2023
shadowusr
commented
Dec 21, 2023
DudaGod
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В остальном /ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done?
...TestResult
types in favor of universalReporterTestResult
assertViewResults
field inReporterTestResult
image-handler
and made formatting imagesInfo a lot easierCache
class insteadimages-info-saver
which performs saving of screenshots and updating paths, it's an almost complete re-write of the oldimage-handler
SqliteTestAdapter
, which can parse sqlite rows directly intoReporterTestResult
Why?
ReporterTestResult
greatly simplifies the way you think about, alter and process test results across the whole appMain chunks of changes:
add...()
methods from report builders, it's pretty obvious