-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prepare html-reporter for pwt GUI integration #522
refactor: prepare html-reporter for pwt GUI integration #522
Conversation
cb4b5f5
to
fc00f1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ refactor: get rid of plugin-adapter
hermione.ts
Outdated
}); | ||
|
||
hermione.on(hermione.events.INIT, async () => { | ||
if (isCliCommandLaunched) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
чет я не понимаю для чего это условие
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это нужно чтобы при запуске cli команд типа gui или любых других команд html-reporter не запускался обычный прогон hermione.
Ранее это было реализовано в PluginAdapter в виде this._run = _.noop
. Сейчас — этим способом.
What's done?
Why?