Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-write GUI to typescript part 3 #521

Merged
merged 5 commits into from
Nov 21, 2023
Merged

chore: re-write GUI to typescript part 3 #521

merged 5 commits into from
Nov 21, 2023

Conversation

shadowusr
Copy link
Member

@shadowusr shadowusr commented Nov 20, 2023 •
edited
Loading

What's done?

  • Being part of the efforts to translate GUI server to typescript, this PR contains final chunks of GUI code re-writes

⚠️ Reviewing commit-by-commit may be more convenient, because diffs would render better in this case.

DudaGod
DudaGod approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

lib/gui/app.ts Show resolved Hide resolved
lib/gui/app.ts Show resolved Hide resolved
lib/gui/routes/plugins.ts Outdated Show resolved Hide resolved
lib/gui/api/index.ts Outdated Show resolved Hide resolved
lib/gui/server.ts Show resolved Hide resolved
@shadowusr shadowusr merged commit f91cf2c into master Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DudaGod DudaGod DudaGod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadowusr @DudaGod