feat: add pwt toMatchScreenshot diff bubbles support #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
approved these changes
Oct 17, 2023
| @@ -252,6 +256,16 @@ export class PlaywrightTestAdapter implements ReporterTestResult { | |||
| return ''; | |||
| } | |||
|
|
|||
| private getDiffClusters(state: string): CoordBounds[] { | |||
| const snapshotName = state + '.png'; | |||
There was a problem hiding this comment.
у нас в state здесь точно не может быть названия с .png? чтобы не получилось plain.png.png
There was a problem hiding this comment.
Этот стейт - от html-reporter.
playwright использует snapshotName, который всегда кончается на .png. Затем добавляет к имени файла суффиксы -expected, -actual, -diff так, что получаются -expected.png, -actual.png, -diff.png.
html-reporter создает свой state путем отбрасывания таких суффиксов вместе с .png
UPD: но в pwt-utils я в name у attachment прокидывал чистый snapshotName, без .png. Сейчас пофикшу
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.