feat(screenshot-accepter): add more space for screenshot view #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
changed the title
sipayRT
force-pushed
the
sp.dontShowImageTitle
branch
from
ac90d7a to
b7ca56b
Compare
sipayRT
changed the title
| outline: 1px solid #ccc; | ||
| border: 1px solid #ccc; |
There was a problem hiding this comment.
А это зачем?
upd: понял
KuznetsovRoman
approved these changes
Oct 4, 2023
sipayRT
force-pushed
the
sp.dontShowImageTitle
branch
from
b7ca56b to
723ce43
Compare
sipayRT
commented
Oct 5, 2023
| @@ -53,6 +56,7 @@ class ScreenshotAccepterBody extends Component { | |||
| <span className="screenshot-accepter__browser-name">{browserName}</span> | |||
| <span className="screenshot-accepter__title-divider">{'/'}</span> | |||
| <span className="screenshot-accepter__state-name">{stateName}</span> | |||
| <span className="screenshot-accepter__images-desc"> ({imagesDescription})</span> | |||
There was a problem hiding this comment.
здесь специально добавил именно пробел, а не margin через css, чтобы отступ всегда был консистентным с размером шрифта
sipayRT
force-pushed
the
sp.dontShowImageTitle
branch
from
723ce43 to
ac135dc
Compare
sipayRT
force-pushed
the
sp.dontShowImageTitle
branch
from
ac135dc to
af01739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
