fix: fix review issues

gemini-testing · Oct 8, 2024 · 895a1cb · 895a1cb
1 parent 877b277
commit 895a1cb
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 18 deletions.
diff --git a/lib/static/new-ui/components/Card/index.module.css b/lib/static/new-ui/components/Card/index.module.css
@@ -3,8 +3,6 @@
     position: relative;
 }
 
-.card {}
-
 .wrapper {
     overflow: hidden;
     box-shadow: rgb(255, 255, 255) 0 0 0 0, rgba(9, 9, 11, 0.05) 0 0 0 1px, rgba(0, 0, 0, 0.05) 0 1px 2px 0;

diff --git a/lib/static/new-ui/components/Card/index.tsx b/lib/static/new-ui/components/Card/index.tsx
@@ -10,7 +10,7 @@ export interface CardProps {
 
 export function Card(props: CardProps): React.ReactNode {
     return <div className={styles.wrapper}>
-        <div className={classNames(styles.commonCard, styles.card, props.className)}>
+        <div className={classNames(styles.commonCard, props.className)}>
             {props.children}
         </div>
     </div>;

diff --git a/lib/static/new-ui/components/SuiteTitle/index.tsx b/lib/static/new-ui/components/SuiteTitle/index.tsx
@@ -31,7 +31,7 @@ export function SuiteTitle(props: SuiteTitlePropsInternal): ReactNode {
                         {item}
                         {index !== suitePath.length - 1 &&
                             <div className={styles.separator}>
-                                <ChevronRight height={11}/>
+                                <ChevronRight height={12}/>
                                 <span className={styles.invisibleSpace}>&nbsp;</span>
                             </div>}
                     </div>
@@ -50,9 +50,9 @@ export function SuiteTitle(props: SuiteTitlePropsInternal): ReactNode {
         </div>
         <div className={styles.paginationContainer}>
             <span className={styles.counter}>{props.index === -1 ? '–' : props.index + 1}/{props.totalItems}</span>
-            <Button view={'flat'} disabled={props.index === -1 || props.index === 0} onClick={props.onPrevious}><Icon
+            <Button view={'flat'} disabled={props.index <= 0} onClick={props.onPrevious}><Icon
                 data={ChevronUp}/></Button>
-            <Button view={'flat'} disabled={props.index === -1 || props.index === props.totalItems - 1} onClick={props.onNext}><Icon
+            <Button view={'flat'} disabled={props.index < 0 || props.index === props.totalItems - 1} onClick={props.onNext}><Icon
                 data={ChevronDown}/></Button>
         </div>
     </div>;

diff --git a/lib/static/new-ui/features/suites/components/SuitesPage/index.module.css b/lib/static/new-ui/features/suites/components/SuitesPage/index.module.css
@@ -20,7 +20,7 @@
 }
 
 .card__title {
-    margin-bottom: 8px !important;
+    margin-bottom: 8px;
     padding-top: 20px;
 }
 

diff --git a/lib/static/new-ui/features/suites/components/SuitesTreeView/selectors.ts b/lib/static/new-ui/features/suites/components/SuitesTreeView/selectors.ts
@@ -91,16 +91,16 @@ export const getTreeViewItems = createSelector(
                 return null;
             }
 
-            const children: TreeViewItem<TreeViewSuiteData | TreeViewBrowserData>[] = [];
+            let children: TreeViewItem<TreeViewSuiteData | TreeViewBrowserData>[] = [];
             if (hasBrowsers(suiteData)) {
-                children.push(...suiteData.browserIds
+                children = suiteData.browserIds
                     .map((browserId) => formatBrowser(browsers[browserId], data))
-                    .filter(Boolean) as TreeViewItem<TreeViewBrowserData>[]);
+                    .filter(Boolean) as TreeViewItem<TreeViewBrowserData>[];
             }
             if (hasSuites(suiteData)) {
-                children.push(...suiteData.suiteIds
+                children = suiteData.suiteIds
                     .map((suiteId) => formatSuite(suites[suiteId], data))
-                    .filter(Boolean) as TreeViewItem<TreeViewSuiteData | TreeViewBrowserData>[]);
+                    .filter(Boolean) as TreeViewItem<TreeViewSuiteData | TreeViewBrowserData>[];
             }
 
             return {data, children};

diff --git a/lib/static/new-ui/features/visual-checks/components/VisualChecksPage/index.module.css b/lib/static/new-ui/features/visual-checks/components/VisualChecksPage/index.module.css
@@ -3,6 +3,6 @@
 }
 
 .card__title {
-    margin-bottom: 8px !important;
+    margin-bottom: 8px;
     padding-top: 20px;
 }
diff --git a/lib/static/new-ui/types/store.ts b/lib/static/new-ui/types/store.ts
@@ -43,7 +43,7 @@ export interface ResultEntityCommon {
     history?: TestStepCompressed[];
     error?: TestError;
     suitePath: string[];
-    /** @node Browser Name/ID, e.g. `chrome-desktop` */
+    /** @note Browser Name/ID, e.g. `chrome-desktop` */
     name: string;
 }
 

diff --git a/lib/static/styles.css b/lib/static/styles.css
@@ -923,36 +923,36 @@ a:active {
 }
 
 /* Gravity UI Font Styles */
+h1, h2, h3, h4, h5, h6 {
+    margin: 0;
+}
+
 .text-display-1 {
     font-family: Jost, sans-serif;
     font-weight: 500;
     font-size: 24px;
     line-height: 28px;
-    margin: 0;
 }
 
 .text-display-2 {
     font-family: Jost, sans-serif;
     font-weight: 500;
     font-size: 18px;
     line-height: 24px;
-    margin: 0;
 }
 
 .text-display-3 {
     font-family: Jost, sans-serif;
     font-weight: 500;
     font-size: var(--g-text-display-3-font-size);
     line-height: var(--g-text-display-3-line-height);
-    margin: 0;
 }
 
 .text-header-1 {
     font-family: Jost, sans-serif;
     font-weight: 500;
     font-size: var(--g-text-header-1-font-size);
     line-height: var(--g-text-header-1-line-height);
-    margin: 0;
 }
 
 .text-subheader-1 {