chore(new-ui): fix missing suites when suite both has nested browsers…

… and suites
gemini-testing · Sep 27, 2024 · 849d140 · 849d140
1 parent 0c05428
commit 849d140
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/lib/static/new-ui/features/suites/components/SuitesTreeView/selectors.ts b/lib/static/new-ui/features/suites/components/SuitesTreeView/selectors.ts
@@ -3,7 +3,8 @@ import {get, last} from 'lodash';
 import {
     isImageEntityFail,
     isResultEntityError,
-    isSuiteEntityLeaf,
+    hasBrowsers,
+    hasSuites,
     BrowserEntity,
     SuiteEntity
 } from '@/static/new-ui/types/store';
@@ -90,21 +91,19 @@ export const getTreeViewItems = createSelector(
                 return null;
             }
 
-            if (isSuiteEntityLeaf(suiteData)) {
-                return {
-                    data,
-                    children: suiteData.browserIds
-                        .map((browserId) => formatBrowser(browsers[browserId], data))
-                        .filter(Boolean) as TreeViewItem<TreeViewBrowserData>[]
-                };
-            } else {
-                return {
-                    data,
-                    children: suiteData.suiteIds
-                        .map((suiteId) => formatSuite(suites[suiteId], data))
-                        .filter(Boolean) as TreeViewItem<TreeViewSuiteData | TreeViewBrowserData>[]
-                };
+            const children: TreeViewItem<TreeViewSuiteData | TreeViewBrowserData>[] = [];
+            if (hasBrowsers(suiteData)) {
+                children.push(...suiteData.browserIds
+                    .map((browserId) => formatBrowser(browsers[browserId], data))
+                    .filter(Boolean) as TreeViewItem<TreeViewBrowserData>[]);
             }
+            if (hasSuites(suiteData)) {
+                children.push(...suiteData.suiteIds
+                    .map((suiteId) => formatSuite(suites[suiteId], data))
+                    .filter(Boolean) as TreeViewItem<TreeViewSuiteData | TreeViewBrowserData>[]);
+            }
+
+            return {data, children};
         };
 
         const tree = rootSuiteIds

diff --git a/lib/static/new-ui/types/store.ts b/lib/static/new-ui/types/store.ts
@@ -21,7 +21,8 @@ export interface SuiteEntityLeaf {
 
 export type SuiteEntity = SuiteEntityNode | SuiteEntityLeaf;
 
-export const isSuiteEntityLeaf = (suite: SuiteEntity): suite is SuiteEntityLeaf => Boolean((suite as SuiteEntityLeaf).browserIds);
+export const hasBrowsers = (suite: SuiteEntity): suite is SuiteEntityLeaf => Boolean((suite as SuiteEntityLeaf).browserIds);
+export const hasSuites = (suite: SuiteEntity): suite is SuiteEntityNode => Boolean((suite as SuiteEntityNode).suiteIds);
 
 export interface BrowserEntity {
     id: string;