fix: fix review issues

lib/report-builder/gui.ts

@@ -186,7 +186,7 @@ export class GuiReportBuilder extends StaticReportBuilder {
     }
 
     private _updateTestResultStatus(testResult: PreparedTestResult, formattedResult: ReporterTestResult): void {
-        if (!hasResultFails(testResult) && !isSkippedStatus(testResult.status)) {
+        if (!hasResultFails(testResult) && !isSkippedStatus(testResult.status) && _.isEmpty(testResult.error)) {
             testResult.status = SUCCESS;
             return;
         }

lib/test-adapter/hermione.ts

@@ -16,7 +16,6 @@ import {
 import {ImagesInfoFormatter} from '../image-handler';
 import {ReporterTestResult} from './index';
 import {getSuitePath} from '../plugin-utils';
-// import {testsAttempts} from './cache/hermione';
 
 const getSkipComment = (suite: HermioneTestResult | HermioneSuite): string | null | undefined => {
     return suite.skipReason || suite.parent && getSkipComment(suite.parent);

lib/test-attempt-manager.ts

@@ -1,71 +1,56 @@
-import _ from 'lodash';
 import {ReporterTestResult} from './test-adapter';
-import {IDLE, RUNNING, SKIPPED, TestStatus, UPDATED} from './constants';
+import {IDLE, RUNNING, TestStatus} from './constants';
 
 type TestSpec = Pick<ReporterTestResult, 'fullName' | 'browserId'>
 
-const INVALID_ATTEMPT = -1;
+interface AttemptData {
+    statuses: TestStatus[];
+}
 
 export class TestAttemptManager {
-    private _attemptMap: Map<string, number>;
-    private _statusMap: Map<string, TestStatus[]>;
+    private _attempts: Map<string, AttemptData>;
 
     constructor() {
-        this._attemptMap = new Map();
-        this._statusMap = new Map();
+        this._attempts = new Map();
     }
 
     removeAttempt(testResult: TestSpec): number {
-        const hash = this._getHash(testResult);
-        let value = this._attemptMap.get(hash);
+        const [hash, data] = this._getData(testResult);
 
-        if (_.isNil(value) || value === 0) {
-            value = INVALID_ATTEMPT;
-        } else {
-            value -= 1;
-
-            const statuses = this._statusMap.get(hash) as TestStatus[];
-            statuses.pop();
+        if (data.statuses.length > 0) {
+            data.statuses.pop();
         }
 
-        this._attemptMap.set(hash, value);
+        this._attempts.set(hash, data);
 
-        return value;
+        return Math.max(data.statuses.length - 1, 0);
     }
 
     getCurrentAttempt(testResult: TestSpec): number {
-        const hash = this._getHash(testResult);
+        const [, data] = this._getData(testResult);
 
-        return this._attemptMap.get(hash) ?? INVALID_ATTEMPT;
+        return Math.max(data.statuses.length - 1, 0);
     }
 
     registerAttempt(testResult: TestSpec, status: TestStatus): number {
-        const hash = this._getHash(testResult);
-
-        let attempt = this._attemptMap.get(hash);
-        const statuses = this._statusMap.get(hash) ?? [];
-
-        if (_.isNil(attempt)) {
-            this._attemptMap.set(hash, 0);
-            statuses.push(status);
-            this._statusMap.set(hash, statuses);
+        const [hash, data] = this._getData(testResult);
 
-            return 0;
+        if (![IDLE, RUNNING].includes(status)) {
+            data.statuses.push(status);
         }
 
-        if ([IDLE, RUNNING, SKIPPED, UPDATED].includes(_.last(statuses) as TestStatus)) {
-            return attempt;
-        }
-
-        attempt += 1;
-        this._attemptMap.set(hash, attempt);
-        statuses.push(status);
-        this._statusMap.set(hash, statuses);
+        this._attempts.set(hash, data);
 
-        return attempt;
+        return Math.max(data.statuses.length - 1, 0);
     }
 
     private _getHash(testResult: TestSpec): string {
         return `${testResult.fullName}.${testResult.browserId}`;
     }
+
+    private _getData(testResult: TestSpec): [string, AttemptData] {
+        const hash = this._getHash(testResult);
+
+        return [hash, this._attempts.get(hash) ?? {statuses: []}];
+    }
 }