Merge pull request #591 from gemini-testing/fix/kroman512/undo/failsu…

…ites fix: undo accept image
gemini-testing · Aug 16, 2024 · 5d0fffd · 5d0fffd
2 parents 30d8ec9 + e48634c
commit 5d0fffd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/static/modules/reducers/tree/nodes/suites.js b/lib/static/modules/reducers/tree/nodes/suites.js
@@ -145,7 +145,7 @@ export function failSuites(tree, suiteIds, diff = tree) {
 
         if (!suite.parentId && !diff.suites.failedRootIds.includes(suite.id)) {
             diff.suites.failedRootIds.push(suite.id);
-        } else {
+        } else if (suite.parentId) {
             processingSuiteIds.push(suite.parentId);
         }
     }

diff --git a/test/unit/lib/static/modules/reducers/tree/index.js b/test/unit/lib/static/modules/reducers/tree/index.js
@@ -1877,6 +1877,18 @@ describe('lib/static/modules/reducers/tree', () => {
 
                 assert.equal(fourthState.tree.suites.byId['s1'].status, FAIL);
             });
+
+            it('should fail parent suites', () => {
+                state.tree.suites.byId['s0'].status = SUCCESS;
+                state.tree.suites.byId['s1'].status = SUCCESS;
+                state.tree.results.byId['r1'].status = STAGED;
+                state.tree.images.byId['i1'].status = STAGED;
+
+                const nextState = reducer(state, {type: actionNames.STATIC_ACCEPTER_UNSTAGE_SCREENSHOT, payload: {imageId: 'i1'}});
+
+                assert.equal(nextState.tree.suites.byId['s0'].status, FAIL);
+                assert.equal(nextState.tree.suites.byId['s1'].status, FAIL);
+            });
         });
     });
 });