Merge pull request #884 from gemini-testing/fix_suite-clone

Suite clone does not clone fullUrl fixed
gemini-testing · Mar 13, 2018 · b2d02ab · b2d02ab
2 parents ee1e695 + 4d9bc62
commit b2d02ab
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/lib/runner/browser-runner/index.js b/lib/runner/browser-runner/index.js
@@ -30,6 +30,7 @@ module.exports = class BrowserRunner extends Runner {
             .map((suite) => {
                 if (suite.hasOwnProperty('url')) {
                     Object.defineProperty(suite, 'fullUrl', {
+                        enumerable: true,
                         get: () => this._mkFullUrl(suite.url)
                     });
                 }

diff --git a/lib/suite.js b/lib/suite.js
@@ -84,7 +84,8 @@ module.exports = class Suite {
         const clonedSuite = Suite.create(this.name, this.parent);
 
         _.forOwn(this, (value, key) => {
-            clonedSuite[key] = _.clone(value);
+            let desc = Object.getOwnPropertyDescriptor(this, key);
+            Object.defineProperty(clonedSuite, key, _.cloneDeep(desc));
         });
 
         this.children.forEach((child) => clonedSuite.addChild(child.clone()));

diff --git a/test/unit/suite.js b/test/unit/suite.js
@@ -342,9 +342,26 @@ describe('suite', () => {
 
         it('should return cloned suite', () => {
             const suite = createSuite('origin');
+            suite.browsers = ['bro1', 'bro2'];
             const clonedSuite = suite.clone();
 
-            assert.notEqual(clonedSuite, suite);
+            assert.deepEqual(clonedSuite, suite);
+            assert.notEqual(clonedSuite, suite); //not equal by link
+            assert.notEqual(clonedSuite.browsers, suite.browsers); //not equal by link
+        });
+
+        it('should clone all enumerable properties', () => {
+            const suite = createSuite('origin');
+            let value = 'some/path';
+            Object.defineProperty(suite, 'fullUrl', {
+                enumerable: true,
+                get: () => value
+            });
+            const clonedSuite = suite.clone();
+
+            assert.equal(clonedSuite.fullUrl, 'some/path');
+            value = 'another/path';
+            assert.equal(clonedSuite.fullUrl, 'another/path');
         });
 
         it('should clone nested suites', () => {