REL-4619 Use the gemini id to identify grating changes #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquiroz
commented
Jan 9, 2025
| @@ -71,20 +71,20 @@ public StageModeNorth parse(String name, StageModeNorth defaultValue) { | |||
| public enum DisperserNorth implements GmosCommonType.Disperser, ObsoletableSpType, IctdType { | |||
| // Mirror isn't tracked but is always installed. | |||
| MIRROR( "Mirror", "mirror", 0, Ictd.installed()), | |||
| B1200_G5301("B1200_G5301", "B1200", 1200, Ictd.track("B1200")), | |||
| R831_G5302( "R831_G5302", "R831", 831, Ictd.track("R831")), | |||
| B1200_G5301("B1200", "B1200", "G5301", 1200), | |||
There was a problem hiding this comment.
I bet this will break serialization
swalker2m
reviewed
Jan 9, 2025
Science preferred solution is not to |
Isn't the old one retired forever? I think we should just change the ITCD tracking id to "R400_old", leave "R400" for the new one and not take chances with changing how it works. If we must make changes, I think what you've done looks reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of a new R400 grating for gmos N, the code to query ICTD from the odb needs an adjustment
This is a proposal for a fix that will query grating using both the name and the gemini id.
For completeness other components should follow the same logic but not every component on ICTD has a gemini id,
This was tested with a local db instance and loading the list of available GmosN gratings.