Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating new generic tests for redshift adapter #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gekas93
Copy link
Owner

@gekas93 gekas93 commented Sep 5, 2024

resolves #
Issue 291 N/A

Problem

When you try to run some test with columns with special characters in the names like '.' or '-' you receive a sintax error.
It happens with each generic test defined.

Solution

We have created a new dbt macros for each test to the redshift adapter that supports special characters adding quotes to the column names.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants