Skip to content

Commit

Permalink
Specify GitHub does not support git://
Browse files Browse the repository at this point in the history
  • Loading branch information
ffaf1 authored and Mikolaj committed Aug 20, 2024
1 parent c63ebf9 commit e581306
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Cabal/src/Distribution/PackageDescription/Check/Warning.hs
Original file line number Diff line number Diff line change
Expand Up @@ -970,7 +970,8 @@ ppExplanation MissingLocation =
"The source-repository 'location' is a required field."
ppExplanation GitProtocol =
"Cloning over git:// might lead to an arbitrary code execution "
++ "vulnerability. Use https:// or ssh:// instead."
++ "vulnerability. Furthermore, popular forges like GitHub do "
++ "not support it. Use https:// or ssh:// instead."
ppExplanation MissingModule =
"For a CVS source-repository, the 'module' is a required field."
ppExplanation MissingTag =
Expand Down
3 changes: 2 additions & 1 deletion cabal-testsuite/PackageTests/Check/GitProtocol/cabal.out
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# cabal check
The following errors are likely to affect your build negatively:
Error: [git-protocol] Cloning over git:// might lead to an arbitrary code
execution vulnerability. Use https:// or ssh:// instead.
execution vulnerability. Furthermore, popular forges like GitHub do not
support it. Use https:// or ssh:// instead.
Error: Hackage would reject this package.

0 comments on commit e581306

Please sign in to comment.